RFR (S): 8229345: Memory leak due to vtable stubs not being shared on SPARC

[Andrew John Hughes]

On 23/01/2020 20:40, Hohensee, Paul wrote:
> Please review this backport to 8u.
> 
> Original JBS issue: https://bugs.openjdk.java.net/browse/JDK-8229345
> Original changeset: https://hg.openjdk.java.net/jdk/jdk/rev/0a8407a78a2f
> Webrev: http://cr.openjdk.java.net/~phh/8229345/webrev.8u.00/
> 
> The backport applied somewhat cleanly. The exceptions were adding 2019 copyright dates, the removal of the unsupported-in-8u globals_aarch64/arm/s390.hpp patches, and a slight difference in the vtableStubs.cpp patch due to 8u not acquiring the VtableStubs_lock.
> 
> Thanks,
> Paul
> 

Generally looks ok, though if we must add these copyright header
changes, should it not be to 2020 now?

Neither I nor diff see any change between the two vtableStubs.cpp
patches. Is there really something different there?

I agree it would be good to check the testcase on SPARC. Any idea why
the test is not part of the backported changeset?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew