[8u] RFR backport JDK-7143743 : (zipfs) Potential memory leak with zip provider

[Andrew John Hughes]

On 24/01/2020 16:45, Hohensee, Paul wrote:
> Lgtm.
> 
> This is what we call a 'clean patch' because it applies cleanly net of file locations/names and line numbers. For those, you don't need to ask for a review, you just tag the JBS issue and note in the fix request comment that the patch applies cleanly. You can get an initial patch suitable for use by 'hg import' using 'hg export'. In this case, in the jdk15 repo (tip), use
> 
> hg export --git -r 57679 > 7143743.patch
> <adapt patch to 8u>
> hg import 7143743.patch
> 
> There's a script that tries to adapt the exported patch to 8u (I've lost track of where it is, perhaps someone can point to it), but it fails more often than not for me so I don't bother with it anymore. I just apply the patch manually and/or update the patch file by hand. It's important to keep the patch metadata so that the import commit info matches the original patch. You can use the same process to adapt a patch that doesn't apply cleanly. See
> 
> https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix
> 
> It's 11u, but explains the 'hg export' process.
> 
> Paul
> 
> On 1/20/20, 6:55 PM, "jdk8u-dev on behalf of Jaikiran Pai" <jdk8u-dev-bounces at openjdk.java.net on behalf of jai.forums2013 at gmail.com> wrote:
> 
>     Would there be interest in backporting the fix for JDK-7143743[1] to
>     Java 8? If so, can I please get a review and a sponsor for the patch
>     which backports it?
>     
>     The original fix that was committed to "jdk" repo resides here[2]. Due
>     to the changes in file paths of the source files, this patch doesn't
>     apply cleanly but is fairly trivial.
>     
>     The webrev containing this backport resides at [3]. I've followed some
>     conventions suggested by Andrew in his recent mail for a similar
>     backport request and have started with a clean list of "Reviewers" in
>     the commit message.
>     
>     
>     [1] https://bugs.openjdk.java.net/browse/JDK-7143743
>     
>     [2] https://hg.openjdk.java.net/jdk/jdk/rev/06331540be15
>     
>     [3] https://cr.openjdk.java.net/~jpai/webrev/7143743-8u/1/webrev/
>     
>     -Jaikiran
>     
>     
>     
> 

Yeah, there are no code changes here, so I don't think changing the
author and reviewers is warranted. Additional reviewers can be appended
to the end.

It doesn't look completely clean as the copyright header context is
different, so I presume more than just path shuffling was needed.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
https://keybase.io/gnu_andrew