[RFC]: Integrate jdk8u-jfr-incubator with jdk8u-dev

Thu Jan 30 11:37:41 UTC 2020

Hi all,

The moment has finally arrived where we are at the point to request
the big merge.

Andrew Hughes was kind enough to provide the webrevs and the list of
bugs, I'm going through them now to mark them for the backport request
but I think there is some need for a last batch of testing before we
finally hit the integration button, and we can take the opportunity to
have a final discussion over those patches during the committer's
workshop.

Before moving on, I wish to thank everyone who was involved in this
effort. This was truly an example in collaboration and was amazing. I
wish to thank in particular:

Andrey Petushkov
Sanhong Li
Jaroslav Bachorik
Marcus Hirt
Ekaterina Vergizova
Denghui Dong
Martin Balao
Jiri Vanek
Andrew Hughes
Aleksey Shipilev
Andrew Haley

And everyone else who was involved either directly or indirectly I am
missing from this list, but has supported the efforts with testing,
suggestions and fixes, and that includes of course the original
authors for most of those fixes.

Also, I wish to thank personally Joe Darcy for his thorough
investigation for the CSR, for his feedback and support.

This is probably the largest backport attempted so far, so while we
had many eyes and spent many hours testing, we know there is still
work to do. Merging this code this early in the cycle between releases
will give us a chance to iron out existing issues before the April
release.

Another note, those changes won't enable JFR automatically, the
configure flag --enable-jfr will still need to be passed, without this
OpenJDK binaries won't have JFR. This is done for compatibility and
also as a safety net.

Ok, without further ado, here's the webrev and the list of changes as
Andrew John Hughes has kindly provided:

https://cr.openjdk.java.net/~andrew/openjdk8/jfr/hotspot/
https://cr.openjdk.java.net/~andrew/openjdk8/jfr/jdk/
https://cr.openjdk.java.net/~andrew/openjdk8/jfr/root/

against jdk8u252-b01 and merge changesets:

https://cr.openjdk.java.net/~andrew/openjdk8/jfr/hotspot/merge.changeset
https://cr.openjdk.java.net/~andrew/openjdk8/jfr/jdk/merge.changeset
https://cr.openjdk.java.net/~andrew/openjdk8/jfr/root/merge.changeset

Changes:
  - S8003209: JFR events for network utilization
  - S8041626: Shutdown tracing event
  - S8165675: Trace event for thread park has incorrect unit for timeout
  - S8195817: JFR.stop should require name of recording
  - S8195818: JFR.start should increase autogenerated name by one
  - S8195819: Remove recording=x from jcmd JFR.check output
  - S8199712: Flight Recorder
  - S8202578: Revisit location for class unload events
  - S8202835: jfr/event/os/TestSystemProcess.java fails on missing events
  - S8203287: Zero fails to build after JDK-8199712 (Flight Recorder)
  - S8203346: JFR: Inconsistent signature of jfr_add_string_constant
  - S8203664: JFR start failure after AppCDS archive created with JFR
StartFlightRecording
  - S8203921: JFR thread sampling is missing fixes from JDK-8194552
  - S8203929: Limit amount of data for JFR.dump
  - S8205516: JFR tool
  - S8207392: [PPC64] Implement JFR profiling
  - S8207829: FlightRecorderMXBeanImpl is leaking the first classloader
which calls it
  - S8209960: -Xlog:jfr* doesn't work with the JFR
  - S8210024: JFR calls virtual is_Java_thread from ~Thread()
  - S8211239: Build fails without JFR: empty JFR events signatures mismatch
  - S8212232: Wrong metadata for the configuration of the cutoff for old
object sample events
  - S8213015: Inconsistent settings between JFR.configure and
-XX:FlightRecorderOptions
  - S8213421: Line number information for execution samples always 0
  - S8213617: JFR should record the PID of the recorded process
  - S8213914: [TESTBUG] Several JFR VM events are not covered by tests
  - S8213917: [TESTBUG] Shutdown JFR event is not covered by test
  - S8213966: The ZGC JFR events should be marked as experimental
  - S8214542: JFR: Old Object Sample event slow on a deep heap in debug
builds
  - S8214750: Unnecessary <p> tags in jfr classes
  - S8214896: JFR Tool left files behind
  - S8214906: [TESTBUG] jfr/event/sampling/TestNative.java fails with
UnsatisfiedLinkError
  - S8214925: JFR tool fails to execute
  - S8215175: Inconsistencies in JFR event metadata
  - S8215237: jdk.jfr.Recording javadoc does not compile
  - S8215284: Reduce noise induced by periodic task getFileSize()
  - S8215362: JFR GTest JfrTestNetworkUtilization fails
  - S8215771: The jfr tool should pretty print reference chains
  - S8216064: -XX:StartFlightRecording:settings= doesn't work properly
  - S8216486: Possibility of integer overflow in JfrThreadSampler::run()
  - S8216559: [JFR] Native libraries not correctly parsed from
/proc/self/maps
  - S8216578: Remove unused/obsolete method in JFR code
  - S8216995: Clean up JFR command line processing
  - S8217744: [TESTBUG] JFR TestShutdownEvent fails on some systems due
to process surviving SIGINT
  - S8217748: [TESTBUG] Exclude TestSig test case from JFR TestShutdownEvent
  - S8218935: Make jfr strncpy uses GCC 8.x friendly
  - S8223147: JFR Backport
  - S8223689: Add JFR Thread Sampling Support
  - S8223690: Add JFR BiasedLock Event Support
  - S8223691: Add JFR G1 Region Type Change Event Support
  - S8223692: Add JFR G1 Heap Summary Event Support
  - S8224172: assert(jfr_is_event_enabled(id)) failed: invariant
  - S8226779: [TESTBUG] Test JFR API from Java agent
  - S8227011: Starting a JFR recording in response to JVMTI VMInit and /
or Java agent premain corrupts memory
  - S8227605: Kitchensink fails "assert((((klass)->trace_id() &
(JfrTraceIdEpoch::leakp_in_use_this_epoch_bit())) != 0)) failed: invariant"
  - S8229366: JFR backport allows unchecked writing to memory
  - S8229401: Fix JFR code cache test failures
  - S8229708: JFR backport code does not initialize
  - S8229873: 8229401 broke jdk8u-jfr-incubator
  - S8230448: [test] JFRSecurityTestSuite.java is failing on Windows
  - S8230707: JFR related tests are failing
  - S8230947: TestLookForUntestedEvents.java is failing after JDK-8230707
  - S8231995: two jtreg tests failed after 8229366 is fixed
  - S8233623: Add classpath exception to copyright in
EventHandlerProxyCreator.java file
  - S8236002: CSR for JFR backport suggests not leaving out the package-info
  - S8236008: Some backup files were accidentally left in the hotspot tree
  - S8236074: Missed package-info
  - S8236174: Should update javadoc since tags
  - S8238076: Fix OpenJDK 7 Bootstrap Broken by JFR Backport

Cheers,
Mario
-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898