[8u] RFR 8151834: Test SmallPrimeExponentP.java times out intermittently

[Andrew Hughes]

On 20/04/2020 21:24, Martin Balao wrote:
> Hi,
> 
> I'd like to request a review for the 8u backport of 8151834 [1]. This
> backport would bring parity with Oracle's JDK. Risk is minimal as only a
> test is affected.
> 
> Webrev.00:
> 
>  *
> http://cr.openjdk.java.net/~mbalao/webrevs/8151834/8151834.webrev.jdk8u.jdk.00/
> 
> Main line patch does not apply cleanly because:
> 
>  * test/sun/security/mscapi/SmallPrimeExponentP.java
>   * 3rd hook
>    * 8u does not have "@key intermittent" line added by 8151835 [2] [3]
>     * backporting 8151835 is not necessary because "@key intermittent"
> will be removed by 8151834 (it was added to make clear that the test was
> intermittently failing, and that's what's being fixed)
>    * "@modules java.base/sun.security.x509" and
> "java.base/sun.security.tools.keytool" lines were not available in 8u
> because the test was not modules-aware. It won't be modules-aware
> anyways but these lines (which will be added by 8151834) are harmless.
> 
> Testing:
> 
>  * test/sun/security/mscapi/SmallPrimeExponentP.java
>   * Passed (tested on Windows)
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8151834
> [2] - https://bugs.openjdk.java.net/browse/JDK-8151835
> [3] - http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/927f20de2cc1
> 

I agree it would be ridiculous to backport JDK-8151835, just to remove
it again with this backport :-)

I would omit the @modules lines. It makes no sense to add them to 8u.

Otherwise, looks good.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222