[8u] RFR 8241888: Mirror jdk.security.allowNonCaAnchor system property with a security one

[Andrew Hughes]

On 21/04/2020 20:49, Martin Balao wrote:
> Hi,
> 
> I'd like to request a review for the 8u backport of 8241888 [1]. For
> further information on why it's desirable to have this in JDK-8, have a
> look at the 8u-CSR [2] (already approved).
> 
> Webrev.00:
> 
>  *
> http://cr.openjdk.java.net/~mbalao/webrevs/8241888/8241888.webrev.jdk8u.jdk.00/
> 
> Main line patch does not apply cleanly because we need to propagate
> java.security change across all java.security-os files. There is nothing
> OS-specific in 8241888 so this change applies to all of them.
> 
> Testing:
> 
>  * Tests in sun/security/validator passed.
>  * Executed my own internal test to make sure that both the Security
> property and the replacement of the System property work fine
>   * Note: no new tests have been proposed as part of the main line patch
> because it's a trivial change and SecurityProperties functionality
> (basis for this patch) is already covered by tests.
> 
> Thanks,
> Martin.-
> 
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8241888
> [2] - https://bugs.openjdk.java.net/browse/JDK-8243285
> 

Looks good to me. Identical to 11u, except that the java.security change
is duplicated for the multiple variants in 8u.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222