[8u] RFR: 8226697: Several tests which need the @key headful keyword are missing it.

[Severin Gehwolf]

Hi Jon,

On Mon, 2020-07-13 at 22:46 +0100, Jonathan Dowland wrote:
> Hello
> 
> Please review this backport of JDK-8226697 to 8u (my first):
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8226697
> (why is it marked resolved? I can't find it applied to jdk8u
> or jdk8u-dev)

It's marked resolved for JDK 14 (the JDK development version at the
time). Backport bugs show up via "Backports" links. In all cases, "Fix
Version" is an important field. For OpenJDK 11 backports there is - in
this case - 11.0.9-oracle and 11.0.9. The former is for OpenJDK 11u,
the latter is for Oracle JDK which doesn't show the commits publicly.
For OpenJDK 8 the versions are, for example, 8u271 and openjdk8u272.
The former is for Oracle JDK 8 (again no public commits) and the latter
for OpenJDK 8u. Since there is no backport bug with Fix Version
openjdk8uXXX, it's not fixed in OpenJDK 8u (yet).


> jdk change: https://hg.openjdk.java.net/jdk/jdk/rev/e7671524d4e2
> 
> 8u patch: attached (if you would prefer a webrev please ask)

The patch looks good.

Next time, please explain whether the JDK 14 patch applied cleanly
(after changing the paths to files) and/or what modifications you had
to do to make it apply. That's helpful for reviewing the patch. Note
that if it applies cleanly it might be that you wouldn't need a review
(just the appropriate label in Jira).

Thanks,
Severin