[8u] 8239385: KerberosTicket client name refers wrongly to sAMAccountName in AD

[Andrew Hughes]

On 15/07/2020 21:02, Martin Balao wrote:
> Hi,
> 
> On 7/15/20 3:39 PM, Zhengyu Gu wrote:
>> I would like to backport this patch to 8u, for parity with Oracle 8u271.
>>
>> Original patch applies cleanly.
>>
>> However, it failed to build, cause it expects
>> sun.security.krb5.Config.getBooleanObject(String... keys) to be public
>> method, while 8u and only 8u, it declares as private. Apparently, the
>> method was partially backported and made it private.
>>
> 
> Yes, indeed. They introduced getBooleanObject method with the backport
> of 8077102 and made it private for some reason. This class is an
> internal class so keeping it public wouldn't have affected the public
> API. getBooleanObject was originally introduced by 8029995 and was public.
> 
> Your backport looks good to me.

Yes, the backport of 8077102 to 8u is a mess. It brings in this method
from 8029995 and alters its signature. Given that, I don't see any harm
in fixing it here. The rest of the backport is clean.

> 
> I believe we will need a CSR before having the approval.

I agree.

> 
> Thanks,
> Martin.-
> 

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222