[8u] RFR(T) 8249610: Make sun.security.krb5.Config.getBooleanObject(String... keys) method public

[Andrew Hughes]

On 16/07/2020 19:10, Zhengyu Gu wrote:
> 
> 
> On 7/16/20 2:06 PM, Andrew Hughes wrote:
>>
>>
>> On 16/07/2020 13:42, Zhengyu Gu wrote:
>>> Please review this trivial patch that makes
>>> sun.security.krb5.Config.getBooleanObject(String... keys) a public
>>> method.
>>>
>>> The method was introduced by JDK-8029995 in jdk9, as a public method,
>>> but made a private method by JDK-8029995 8u backport.
>>>
>>> This blocks JDK-8239385 8u backport.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8249610
>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8249610/webrev.00/
>>>
>>> Test:
>>>    jdk_security
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>>
>>
>> If you want 8239385 to be clean, this one needs to just make the access
>> change, and not alter the copyright :-)
> 
> Okay, I will revert copyright change.
> 
> Can I count this as a review?
> 
> Thanks,
> 
> -Zhengyu
> 
>>
>> Thanks,
>>
> 

Yeah, Martin & I effectively already reviewed this in the 8239385 thread.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222