[8u] RFR 8183349: Better cleanup for jdk/test/javax/imageio/plugins/shared/CanWriteSequence.java and WriteAfterAbort.java

[Andrew Hughes]

On 21/07/2020 16:53, Severin Gehwolf wrote:
> Hi Zhengyu!
> 
> On Tue, 2020-06-16 at 20:48 -0400, Zhengyu Gu wrote:
>>
>> On 6/16/20 7:43 PM, Andrew Hughes wrote:
>>>
>>> On 16/06/2020 22:09, Zhengyu Gu wrote:
>>>> Please review this backport for parity with Oracle 8u271.
>>>>
>>>> The original patch does not apply cleanly. The conflicts are minor, as
>>>> 8u version of CanWriteSequence.test() method format is slightly off.
>>>>
>>>> Original bug:  https://bugs.openjdk.java.net/browse/JDK-8183349
>>>> Original patch: http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/93b7bd25273e
>>>>
>>>> 8u weberv: http://cr.openjdk.java.net/~zgu/JDK-8183349-8u/webrev.00/
>>>>
>>>> Test:
>>>>    Passed both tests on Linux x86_64
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> -Zhengyu
>>>>
>>>
>>> Where are the indentation differences coming from in this patch? The
>>> only difference between the 8u and 10u version of this file prior to the
>>> patch is the latter has a newline at the end.
>>>
>> Right. Adding a newline in 8u version, then patch applied cleanly.
>>
>> Do I still need a review?
> 
> Adding a new-line at the end of the file is fine. Reviewed.
> 
> If in doubt, post a review :) In this case, I'd have approved the patch
> if it was mentioned in the fix request comment *without* a review.
> 
> Thanks,
> Severin
> 

If the patch applies with automated path shuffling via the in-tree
scripts, and then builds, it is fine to proceed straight to the approval
process. Otherwise, a review is necessary.

This is documented on the wiki:
https://wiki.openjdk.java.net/display/jdk8u/Main
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222