[8u] TLSv1.3 RFR: 8245474: Add TLS_KRB5 cipher suites support according to RFC-2712
Alexey Bakhtin
alexey at azul.com
Tue Jul 21 19:34:35 UTC 2020
Hi Martin,
Looks good to me.
Thank you
Alexey
> On 21 Jul 2020, at 19:50, Martin Balao <mbalao at redhat.com> wrote:
>
> Hi Alexey,
>
> Thanks for your feedback.
>
> Webrev.04:
> http://cr.openjdk.java.net/~mbalao/webrevs/8245474/8245474.webrev.04/
>
> On 7/21/20 11:24 AM, Alexey Bakhtin wrote:
>> KrbClientKeyExchange.java - krb5Helper is initialized in constructor and should not be changed later. It could be final.
>
> Fixed.
>
>> - SecretKey and KerberosKey are not used in Krb5ProxyImpl and could be removed from imports. If it is applied, KerberosKey should be also removed in refs.allowed script for Krb5ProxyImpl class,
>
> Fixed.
>
>> - SecretKey is not used in Krb5Proxy and could be removed from imports,
>
> Fixed.
>
>> - Krb5Helper.isAvailable() method is not used also and could be removed.
>
> Fixed.
>
> Thanks,
> Martin.-
>
More information about the jdk8u-dev
mailing list