[8u] RFR: 8249677: Regression after JDK-8237117: Better ForkJoinPool behavior

Andrew Hughes gnu.andrew at redhat.com
Wed Jul 22 19:42:38 UTC 2020



On 22/07/2020 19:27, Anton Kozlov wrote:
> 
> 
> On 22.07.2020 20:22, Andrew Hughes wrote:
>>>
>>> http://cr.openjdk.java.net/~akozlov/8249677/webrev.02/
>>>
>>
>> I think this is wrong. The whole purpose of having a test is to catch
>> bugs. The test *should* be failing until either a fix is in place or we
>> make a decision to not fix it.
>>
>> I'm fine with adding the bug ID, comment and output that will help
>> anyone running the test know we're aware of the issue. I'd also still
>> like to see the comment added I suggested in my first review of this [0].
>>
>> [0] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-July/012198.html
> 
> My bad, comment is certainly needed. I have also uncommented the test case.
> 
> http://cr.openjdk.java.net/~akozlov/8249677/webrev.03/
> 
> Thanks,
> Anton
> 

Thanks. I'm happy with this version.

Please flag for approval.
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222



More information about the jdk8u-dev mailing list