[8u] RFR: 8249677: Regression after JDK-8237117: Better ForkJoinPool behavior
Severin Gehwolf
sgehwolf at redhat.com
Thu Jul 23 14:54:34 UTC 2020
Hi,
On Thu, 2020-07-23 at 11:46 -0300, Martin Balao wrote:
> Hi,
>
> On 7/23/20 3:20 AM, Anton Kozlov wrote:
> >
> > On 22.07.2020 22:52, Anton Kozlov wrote:
> > > On 22.07.2020 22:42, Andrew Hughes wrote:
> > > > > http://cr.openjdk.java.net/~akozlov/8249677/webrev.03/
> > > > >
> > > >
> > > > Thanks. I'm happy with this version.
> > > >
> >
> > Thanks for approval.
> > We'll push as soon as 8u be merged into 8u-dev.
> >
>
> Even though your Webrev.03 patch has been reviewed and
> maintainer-approved, I believe we should revisit the 'testDefault'
> decision before pushing. It's not clear to me yet whether 'testDefault'
> behaviour will be 'expected' or 'unexpected'. In any case, that will be
> addressed in the context of 8249846 [1].
Yes, agreed.
To proceed with this fix I suggest the following: Please remove
testDefault code and references to 8249846
from test/java/util/concurrent/forkjoin/AccessControlContext.java
It wouldn't be the right call to commit that under 8249677. The test
and the fix (if any) should come with the changeset for 8249846.
Thanks,
Severin
> Thanks,
> Martin.-
>
> --
> [1] - https://bugs.openjdk.java.net/browse/JDK-8249846
>
More information about the jdk8u-dev
mailing list