RFR[8u] JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors

[Severin Gehwolf]

Hi Leslie,

Thanks for your patience.

On Fri, 2020-07-24 at 00:31 +0800, Leslie Zhai wrote:
> Hi Severin,
> 
> 在 7/23/20 4:49 PM, Severin Gehwolf 写道:
> > Hi Leslie,
> > 
> > On Thu, 2020-07-23 at 10:27 +0800, Leslie Zhai wrote:
> > > Hi Patrick,
> > > 
> > > Thanks for your kind response!
> > > 
> > > 
> > > 在 2020年07月23日 10:13, Patrick Zhang OS 写道:
> > > > Hi Leslie,
> > > > 
> > > > Thanks for the proposed backport, it is good to me (not a reviewer here). I noticed the patches had been backported to 11u last week.
> > > > 
> > > > A reminder: you probably need to add "jdk8u-fix-request" at all the three sub-tasks, provide a webrev if it could not be applied cleanly,  then ask for maintainers' approval. FYI, the process: https://wiki.openjdk.java.net/display/jdk8u
> > > I added "jdk8u-fix-request" label at all the three sub-tasks.
> > The -fno-common fixes were actually pushed to jdk head via 3 different
> > bugs:
> > https://bugs.openjdk.java.net/browse/JDK-8238380
> > https://bugs.openjdk.java.net/browse/JDK-8238386
> > https://bugs.openjdk.java.net/browse/JDK-8238388
> > 
> > Getting the fixes backported to JDK 8u should follow the same process.
> > That is, for each bug there should be a RFR (if needed), get it
> 
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-July/012249.html
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-July/012248.html
> https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-July/012250.html

Thanks.

Please wait for each thread to conclude review before applying for JDK
8u backports approval via the "jdk8u-fix-request" label. In the "Fix
Request" comment mention the jdk8u Reviewer who approved your patch and
add a link to the RFR and webrev. Explain the risk assessment you've
done and the testing of the patch you've carried out. Example:

https://bugs.openjdk.java.net/browse/JDK-8194298?focusedCommentId=14347472&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14347472


> > reviewed by a jdk8u project Reviewer, and finally, once the patch got
> > properly reviewed, the jdk8u-fix-request label can be added with a
> > *relevant* "Fix Request"[1] comment so as to apply for Maintainer
> > approval.
> > 
> > Please see "Contributing" section in:
> > https://wiki.openjdk.java.net/display/jdk8u
> > 
> > So in this case your proposals are missing a couple of requirements:
> > - No fix request comment
> 
> It is also able to reproduce the issue for jdk8u-dev when compiling with 
> GCC 10.
> 
> And it is able to compile with GCC 10 after applied the patchset:
> 
> $ ./configure --with-debug-level=fastdebug 
> --with-jtreg=/home/zhaixiang/jtreg
> 
> $ WARNINGS_ARE_ERRORS=-Wall make test JOBS=12

OK, I get that :)

What I meant to describe in my previous email was that in order to
request approval for a JDK 8u backport, certain steps need to be taken.
It's *not* sufficient to just add label jdk8u-fix-request to a bug
*without* a "Fix Request" comment like was done in your case. Hence my
comment about "No fix request comment" in the earlier email.

I hope that makes some sense.

Thanks,
Severin


> > - It's not clear whether or not the patch applies as is
> >    or not. Did it require a review? Who approved the review?
> > 
> > For that reason, I've removed the jdk8u-fix-request labels for them.
> > Please add them back once the requirements for flagging for approval
> > have been satisfied. There are many bugs to be considered for approval
> > and it is a waste of resources to look at bugs which aren't ready for
> > Maintainer approval yet. There is only 3 of us and we are all busy.
> > 
> > Thanks for your understanding!
> > 
> > Cheers,
> > Severin
> > 
> > [1] https://openjdk.java.net/projects/jdk-updates/approval.html
> > 
> > 
> > 
> > > > Regards
> > > > Patrick
> > > > 
> > > > -----Original Message-----
> > > > From: Leslie Zhai <zhaixiang at loongson.cn>
> > > > Sent: Wednesday, July 22, 2020 9:41 PM
> > > > To: Patrick Zhang OS <patrick at os.amperecomputing.com>
> > > > Cc: jdk8u-dev at openjdk.java.net
> > > > Subject: RFR[8u] JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors
> > > > 
> > > > Hi Patrick,
> > > > 
> > > > I would like to backport the fix for:
> > > > 
> > > > https://bugs.openjdk.java.net/browse/JDK-8235903
> > > > 
> > > > To OpenJDK 8 updates dev:
> > > > 
> > > > http://hg.openjdk.java.net/jdk8u/jdk8u-dev
> > > > 
> > > > The fix is mostly the same as the version that was committed in 15.
> > > > 
> > > > Webrev: http://cr.openjdk.java.net/~lzhai/8235903-8u/
> > > Do I need to dive the patch into three small ones?
> > > 
> > > Thanks,
> > > Leslie Zhai
> > > 
> > > > Thanks,
> > > > 
> > > > Leslie Zhai
> > > >