[8u] RFR: 8249677: Regression after JDK-8237117: Better ForkJoinPool behavior

Severin Gehwolf sgehwolf at redhat.com
Thu Jul 23 17:23:28 UTC 2020


Hi Anton,

On Thu, 2020-07-23 at 19:58 +0300, Anton Kozlov wrote:
> Hi,
> 
> On 23.07.2020 17:54, Severin Gehwolf wrote:
> > On Thu, 2020-07-23 at 11:46 -0300, Martin Balao wrote:
> > > Even though your Webrev.03 patch has been reviewed and
> > > maintainer-approved, I believe we should revisit the 'testDefault'
> > > decision before pushing. It's not clear to me yet whether 'testDefault'
> > > behaviour will be 'expected' or 'unexpected'. In any case, that will be
> > > addressed in the context of 8249846 [1].
> > 
> > Yes, agreed.
> > 
> > To proceed with this fix I suggest the following: Please remove
> > testDefault code and references to 8249846
> > from test/java/util/concurrent/forkjoin/AccessControlContext.java
> > It wouldn't be the right call to commit that under 8249677. The test
> > and the fix (if any) should come with the changeset for 8249846.
> 
> I personally don't have a strict opinion about the test case.
> I specifies the behavior of 8u262, I don't think it is certainly 
> wrong to have one before 8249846.
> 
> For simplicity of logistics, we can remove the case until resolution 
> for 8249846. Not sure what we'll decide for the test case if we also 
> decide not to fix 8249846. But this is not really important now, I agree.
> New webrev with proposed changes:
> 
>   http://cr.openjdk.java.net/~akozlov/8249677/webrev.04/

This looks good. Thanks for the update!

Cheers,
Severin



More information about the jdk8u-dev mailing list