[8u] RFR(S): 8247817: Some incompatible APIs in jdk/test/lib

[Liu, Xin]

hi, Paul and Severin, 

I redo this per your feedbacks on JBS. here is the new revision.
Could you take a look?

Webrev: https://cr.openjdk.java.net/~xliu/8247817/01/webrev/
JBS: https://bugs.openjdk.java.net/browse/JDK-8247817

changes since last revision.
1. I remove SkippedException from jdk.  I move it to my vmTestBase patchset. 
2. I detect a merging conflicts in Platform.java. the method sharedLibraryPathVariableName() has been added in JDK-8238225
I drop mine. 

thanks,
--lx


________________________________________
From: Hohensee, Paul
Sent: Friday, June 19, 2020 10:04 AM
To: Liu, Xin; jdk8u-dev at openjdk.java.net
Subject: Re: [8u] RFR(S): 8247817: Some incompatible APIs in jdk/test/lib

Thank you, Xin. Lgtm.

Paul

On 6/18/20, 4:00 PM, "Liu, Xin" <xxinliu at amazon.com> wrote:

    hi, Paul,

    I believe those code were brought in from upstream for JFR, but JFR
    testing may not cover them.
    I am working a new patchset which allows users to run vmtestbase using
    jdk/test/lib of jdk repo. I ran into those problems when I execute
    vmtestcase.

    for example,
    http://cr.openjdk.java.net/~xliu/8247817/00/webrev/test/lib/jdk/test/lib/util/JarUtils.java.udiff.html
    This class makes use InputStream.transferTo, which is available since jdk9
    (https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/io/InputStream.html#transferTo(java.io.OutputStream)

    It can't be compiled with the runtime of jdk8u.

    Other 3 symbols like Platform.sharedLibraryPathVariableName(),
    Utils.TEST_ROOT and jtreg.SkippedException are all symbols referred by
    hotspot/test/vmTestbase.
    yes, we can recursively backport them, but it is time-consuming and
    introduce a lot of less irrelevant code. They are all incremental
    changes which won't incur any conflict.

    thanks,
    --lx

    On 6/18/20 2:27 PM, Hohensee, Paul wrote:
    > Would you describe the problems you encountered that this patch solves please? The Whitebox issue is obvious, but the purpose of the other changes isn't.
    >
    > Thanks,
    > Paul
    >
    > On 6/17/20, 5:29 PM, "jdk8u-dev on behalf of Liu, Xin" <jdk8u-dev-bounces at openjdk.java.net on behalf of xxinliu at amazon.com> wrote:
    >
    >      Hi, maintainers,
    >
    >      Could you review this webrev for jdk8u-dev/jdk?
    >
    >      Bug: https://bugs.openjdk.java.net/browse/JDK-8247817
    >
    >      Webrev: http://cr.openjdk.java.net/~xliu/8247817/00/webrev/
    >
    >
    >      Description:
    >
    >      I ran into these problems when I try to use jdk/test/lib of jdk repo,
    >      which was introduced for JFR testing,  to run hotspot/test/vmtestbase.
    >
    >      I guess the JFR testing doesn't cover them. IMHO, we'd better fix them
    >      for jdk8u, Otherwise we will observe something strange when we really
    >      use them.
    >
    >      eg. The whitebox api isMethodCompilable doesn't work. It's because
    >      CompLevel_any=-1 in jdk8u. Whitebox APIs must be consistent with the
    >      implementation of hotspot.
    >
    >      thanks,
    >
    >      --lx
    >
    >
    >