[8u] RFR 8148854: Class names "SomeClass" and "LSomeClass;" treated by JVM as an equivalent

Andrew Hughes gnu.andrew at redhat.com
Tue Jul 28 05:12:58 UTC 2020


On 14:32 Mon 27 Jul     , Zhengyu Gu wrote:
> I would like to backport this to 8u for parity with Oracle 8u281.
> 
> The original patch does not apply cleanly.
> 
> 1) classFileParser.cpp
>    8u does not have the changes from JDK-8140485, so relaxed class file
> check is performed from ClassFileParser::parseClassFile, instead of
> ClassFileParser's constructor.
>    The conflicts are easy to resolve.
> 
> 2) verifier.hpp
>   Copyright line already updated in 8u
> 
> 3) FormatCheckingTest.java
>   Changed @library from /test/lib -> /testlibrary
>   Changed imports to reflect test library changes
>   Removed @modules
> 
> 
> Original bug: https://bugs.openjdk.java.net/browse/JDK-8148854
> Original patch:
> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/92e705c1e6e6
> 
> 8u Webrev: http://cr.openjdk.java.net/~zgu/JDK-8148854-8u/webrev.00/
> 
> Test:
>   hotspot/runtime
> 
> Thanks,
> 
> -Zhengyu
> 

Changes look good. The same ext_class_loader* to
platform_class_loader* conversion is visible when comparing the
annotation_index method in the same file between 8u and 9u, so seems
correct.

Funny that this bug says "8-wnf", yet there is a backport listed for 8u281 :/

Is it worth waiting until 8u272 branches before committing this?

Thanks,
--
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


More information about the jdk8u-dev mailing list