[8u] RFR(S): 8247817: Some incompatible APIs in jdk/test/lib

[Andrew Hughes]

On 05:44 Mon 27 Jul     , Liu, Xin wrote:
> hi, Paul and Severin, 
> 
> I redo this per your feedbacks on JBS. here is the new revision.
> Could you take a look?
> 
> Webrev: https://cr.openjdk.java.net/~xliu/8247817/01/webrev/
> JBS: https://bugs.openjdk.java.net/browse/JDK-8247817
> 
> changes since last revision.
> 1. I remove SkippedException from jdk.  I move it to my vmTestBase patchset. 
> 2. I detect a merging conflicts in Platform.java. the method sharedLibraryPathVariableName() has been added in JDK-8238225
> I drop mine. 
> 
> thanks,
> --lx
> 

The real problem here seems to be that none of these files should
actually exist, because they duplicate existing versions in 8u:

JFR: test/lib/jdk/test/lib/util/JarUtils.java
8u: test/lib/testlibrary/jdk/testlibrary/JarUtils.java

JFR: test/lib/jdk/test/lib/Utils.java
8u: test/lib/testlibrary/jdk/testlibrary/Utils.java

JFR: jdk/test/lib/sun/hotspot/WhiteBox.java
8u: hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java

Comparing these shows that the 8u version already avoids transferTo
in favour of routines in Utils.

So the correct solution here is to delete these duplicates and
then fix any tests referring to the wrong version, as should have
been done for the initial backport.

We shouldn't be maintaining two copies of the test library.

It's not clear to me what the TEST_ROOT addition in the patch is for,
as I don't see TEST_ROOT referenced anywhere in current 8u jdk/test
Java code.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222