[8u] RFR (S) 8046274: Removing dependency on jakarta-regexp

Severin Gehwolf sgehwolf at redhat.com
Tue Jul 28 13:02:46 UTC 2020


On Tue, 2020-07-28 at 12:38 +0200, Aleksey Shipilev wrote:
> On 7/3/20 10:16 AM, Severin Gehwolf wrote:
> > On Fri, 2020-03-27 at 12:23 +0100, Aleksey Shipilev wrote:
> > > Original change:
> > >   https://bugs.openjdk.java.net/browse/JDK-8046274
> > >   https://hg.openjdk.java.net/jdk9/jdk9/jaxp/rev/bfc9ec1a816b
> > > 
> > > Patch does not apply cleanly to 8u, because paths are different. I have removed
> > > src/com/sun/org/apache/regexp/ by hand. Reapplied THIRD_PARTY_README by hand. InstructionFinder.java
> > > change applies after reshuffling.
> > > 
> > > 8u webrev:
> > >   https://cr.openjdk.java.net/~shade/8046274/webrev.8u.01/
> > > 
> > > Testing: java/xml tests, tier1
> > 
> > This looks good to me.
> 
> Thanks, I added the tags.
> 
> > Please be sure to push THIRD_PARTY_README changes to all 8 repositories
> > once you've got approval.
> 
> Okay. It would deviate from the jdk9 changeset, but I think it was jdk9 (JDK-8169925) that merged
> the THIRD_PARTY_README-s together. So it does make some sense to update all of them in 8u...

That's how we need to handle THIRD_PARTY_README changes.

> The final push would be like this:
>   https://cr.openjdk.java.net/~shade/8046274/webrev.8u.02/

Yes.

Thanks,
Severin



More information about the jdk8u-dev mailing list