[8u] TLSv1.3 RFR: 8245477: Adjust TLS tests location

Martin Balao mbalao at redhat.com
Tue Jul 28 19:41:54 UTC 2020


Hi Alexey,

On 7/28/20 1:29 PM, Alexey Bakhtin wrote:
> Git diff for the JDK-8245477 webrev.v2 is available at :
> http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245477/webrev.v2/jdk.git.diff
> Original jdk.patch in the webrev.v2 does not move binary files
> 

Thanks for providing that!

My thinking was that generating a Webrev after committing the change
locally was, in all cases, generating the proper git patch with all the
binaries relocated. Then I realized that when you specify a revision (-r
argument to webrev.ksh), it does not: only when you generate the webrev
against the remote repository (and changes were committed). There is not
much risk of messing this up without any notice because most of the test
cases will fail.

So I'll take your jdk.git.diff as valid here, even if the generated
jdk.patch on your Webrev is not ready to be applied and I did not review
jdk.git.diff. Note: diffing jdk.patch and jdk.git.diff brings pure noise.

Kind regards,
Martin.-



More information about the jdk8u-dev mailing list