[8u] RFR: 8237951: CTW: C2 compilation fails with "malformed control flow"

[Andrew Hughes]

On 31/03/2020 14:22, Roland Westrelin wrote:
> 
> The patch from the fix applies cleanly but it relies on
> Node::find_out_with() that's missing from 8. The backport below cherry
> picks that method from 8066312 (Add new Node* Node::find_out(int opc)
> method).
> 
> http://cr.openjdk.java.net/~roland/8237951.8u/webrev.00/
> 
> Initial change:
> https://bugs.openjdk.java.net/browse/JDK-8237951
> https://hg.openjdk.java.net/jdk/jdk/rev/c7152f7e01a6
> 
> Tested with tier1.
> 
> Roland.
> 

Hmm, I'm not sure we should be cherry-picking this function for just the
one use case. For consistency, we should either bring in JDK-8066312
(which doesn't amount to much more than is cherry-picked here) or
replace the call in this patch with the function body, as is the case in
other places in the code e.g.

https://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/file/f7691a80458c/src/share/vm/opto/escape.cpp#l3105

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222