RFR: 8245167: Top package in method profiling shows "null" in JMC

[Mario Torre]

I think this should be in by release, so I support the use of a
critical fix label.

Cheers,
Mario

On Wed, Jun 3, 2020 at 10:41 AM Jaroslav Bachorík
<jaroslav.bachorik at datadoghq.com> wrote:
>
> Hi,
>
> would it be possible to move this forward? Also, since this patch is
> adding quite valuable information to JFR recordings and it missed the
> 8u262 cutoff very narrowly would it be possible to even consider it as
> a part of critical fix process?
>
> Thanks!
>
> -JB-
>
> On Wed, May 27, 2020 at 1:46 PM Mario Torre <neugens at redhat.com> wrote:
> >
> > Hi Andrey,
> >
> > I went through the patch and it looks good.
> >
> > As we discussed offline, I have doubts and concerns about the handling
> > in "package_from_name" of packages that start with L but this is part
> > of the original patch and not specific to the backport, so I think
> > this should be handled upstream later and explore if there are indeed
> > issues.
> >
> > I'm CC'ing Andrew Haley and Andrew Dinn to request the approval and a
> > second eye if necessary.
> >
> > Cheers,
> > Mario
> >
> >
> > On Mon, May 18, 2020 at 12:30 PM Andrey Petushkov <andrey at azul.com> wrote:
> > >
> > > Dear All,
> > >
> > > please consider the following patch to add missing package information
> > > into JFR backport
> > > https://cr.openjdk.java.net/~apetushkov/8245167/
> > >
> > > Originally the package info was omitted due to dependency on jigsaw
> > > functionality and hence it was thought it's not much relevant for jdk8.
> > > However it turns out it's widely used (e.g. by JMC). So it makes sense
> > > to implement it in jdk8-specific way
> > >
> > > The author of the code is Aleksei Semenov <asemenov at azul.com>
> > >
> > > Verified by JMC and jfr jtreg tests, including the fixed
> > > jdk/jfr/event/runtime/TestClassLoadEvent
> > >
> > > Thanks,
> > > Andrey
> > >
> >
> >
> > --
> > Mario Torre
> > Associate Manager, Software Engineering
> > Red Hat GmbH <https://www.redhat.com>
> > 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
> >
>


-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898