[8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

[Mario Torre]

On Wed, Jun 3, 2020 at 9:52 AM Jaroslav Bachorík
<jaroslav.bachorik at datadoghq.com> wrote:
> Thanks to Mario Torre for pointing me the right direction! I was able
> to add a rudimentary test which exhibits JVM crash without this patch
> applied and passes with this patch (with an exception and error
> message as specified - no JVM crash).
>
> Webrev: http://cr.openjdk.java.net/~jbachorik/8233197/hotspot/webrev.03/
> (also including the requested indentation change)

There's something weird about this:
--- a/test/runtime/8001071/Test8001071.sh
+++ b/test/runtime/8233197/Test8233197.sh

It's registered as a copy/replacement. I think it should be a new file though.

One more nit, is that you don't need the printfs, i.e.:

printf("Agent_OnLoad\n");

The test case looks good otherwise for our purposes, but I'll let
Andrew have the final words.

> BTW, since this patch missed the cutoff date for 8u262 mostly due to
> review would it be ok to consider it still as a part of the critical
> fix process?

I most certainly support this.

Cheers,
Mario

-- 
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898