[8u] TLSv1.3 RFR: 8245472: Backport JDK-8038893 for TLSv1.3
Martin Balao
mbalao at redhat.com
Thu Jun 4 19:41:17 UTC 2020
On 6/4/20 4:30 PM, Alexey Bakhtin wrote:
>> * sun/security/util/HostnameChecker.java
>> * Shouldn't "SSLLogger.isOn" be "SSLLogger.isOn && SSLLogger.isOn("ssl")"?
>
> Yes, you are right. Fixed
Actually, you were right (see below).
>
>> * Things being logged do not look for a "fine" level to me, as they
>> are errors on the certificate DNS name. In 8038893, these messages were
>> sent to "System.err". What do you think?
>
> In the original patch for JDK9 it is logged as debug.println
> In the JDK11 it was changed to SSLLogger.fine()
> So, I think we should keep it “fine”
>
Ah, you are right! It's "fine" and "SSLLogger.isOn" in JDK-11,
introduced by 8196584. I got lost in the patch-to-patch comparison.
Would you mind reverting the "SSLLogger.isOn("ssl")" part? Sorry about
that. Last thing I ask before approval.
More information about the jdk8u-dev
mailing list