[8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

[Andrew Hughes]

On 28/05/2020 17:25, Jaroslav Bachorík wrote:
> On Thu, May 28, 2020 at 3:10 PM Andrew Hughes <gnu.andrew at redhat.com> wrote:
>>
>>
>>
>> On 28/05/2020 13:34, Andrew Haley wrote:
>>> On 28/05/2020 10:08, Jaroslav Bachorík wrote:
>>>> I guess so. But such a test is not a part of the original changeset.
>>>> Is it necessary to be extending the scope of the original patch
>>>> (https://hg.openjdk.java.net/jdk/jdk/rev/127ca611f19b)?
>>>
>>> Yes please. 8u is old code, and your first task is not to break it. If
>>> this involves being more defensive than upstream, that's fine. Class
>>> initialization order at startup is notoriously sensitive and responsible
>>> for breaking things in subtle ways.
>>>
>>
>> There's also no reason such a change could not then be forwardported to
>> later versions. If a bug is filed for this, the 8u fix can be committed
>> under both 8233197 & the new ID, and then the test change alone posted
>> for review in later versions.
> 
> Well, there might be a reason - there is no 'native test' support in
> JDK 8 AFAIK. There are not even any JVMTI native agent jtreg tests -
> so no harness for building a native agent (on all supported
> platforms). And to be honest, I don't feel like writing all that
> support from scratch. If I am missing something and there indeed is a
> support for testing JVMTI agents, please let me know and I will add a
> test.
> 
> Thanks!
> 
> -JB-
> 

Sorry, I'm lost here. How does a lack of support for testing in 8u mean
it can't be forwardported to later JDK versions?

As I see there now is a test for 8u, could a bug be filed so we can
track getting this test into all currently supported versions?

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222