RFR: 8234617: C1: Incorrect result of field load due to missing narrowing conversion

[Hohensee, Paul]

Thanks,

Paul

On 6/9/20, 1:14 PM, "Sergey Nazarkin" <snazarkin at azul.com> wrote:

    It is updated and placed under the same webrev

    http://cr.openjdk.java.net/~snazarki/jdk8u-dev-webrev/8234617/



    Sergey Nazarkin




    > On Jun 9, 2020, at 23:10, Hohensee, Paul <hohensee at amazon.com> wrote:
    >
    > Need to update the webrev with the correct test location.
    >
    > Paul
    >
    > On 6/9/20, 1:02 PM, "Sergey Nazarkin" <snazarkin at azul.com> wrote:
    >
    >    Updated review and marked the bug
    >
    >
    >    Sergey Nazarkin
    >
    >
    >
    >
    >> On Jun 9, 2020, at 20:38, Hohensee, Paul <hohensee at amazon.com> wrote:
    >>
    >> You're correct, I missed that. They should indeed go under hotspot/test/compiler/conversions, which is a new directory in jdk8. There's no global test directory and no hotspot/jtreg directory in jdk8.
    >>
    >> Thanks,
    >> Paul
    >>
    >> On 6/9/20, 9:45 AM, "Sergey Nazarkin" <snazarkin at azul.com> wrote:
    >>
    >>   Thanks, Paul
    >>
    >>   One question regarding new tests path. The files are placed according to non-jdk8 rules. Shouldn’t them be placed under test/compiler/conversions/ folder?
    >>
    >>
    >>   Sergey Nazarkin
    >>
    >>
    >>
    >>
    >>> On Jun 9, 2020, at 00:10, Hohensee, Paul <hohensee at amazon.com> wrote:
    >>>
    >>> Lgtm, assuming TestPrimitiveConversions.java passes. Worth doing because it's a simple fix, for a bug which can manifest as data corruption.
    >>>
    >>> Thanks,
    >>> Paul
    >>>
    >>> On 6/8/20, 12:24 PM, "jdk8u-dev on behalf of Sergey Nazarkin" <jdk8u-dev-bounces at openjdk.java.net on behalf of snazarkin at azul.com> wrote:
    >>>
    >>>  Original change
    >>>  https://jira.azulsystems.com/browse/JDK-8234617
    >>>
    >>>  I’m not sure 8u need this but the fix reminds me recent BBB issue.
    >>>
    >>>  If we need this the patch is following
    >>>  webrev
    >>>  http://cr.openjdk.java.net/~snazarki/jdk8u-dev-webrev/8234617/
    >>>
    >>>  c1_GraphBuilder is patched cleanly after path correction
    >>>  TestPrimitiveConversions.java needs correct Asserts.java path
    >>>
    >>>
    >>>  Sergey
    >>>
    >>>
    >>>
    >>>
    >>>
    >>
    >>
    >
    >