[8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

Jaroslav Bachorík jaroslav.bachorik at datadoghq.com
Thu Jun 11 15:44:12 UTC 2020


Hi,

On Thu, Jun 11, 2020 at 4:36 PM Andrew Dinn <adinn at redhat.com> wrote:
>
> Hi Jaroslav,
> On 11/06/2020 11:50, Jaroslav Bachorík wrote:
> > I have reverted the change in the class initialization order and put
> > the JvmtiExport change in a guarded block as requested.
> > All tests are passing.
> . . .
> > The latest webrev:
> > http://cr.openjdk.java.net/~jbachorik/8233197/hotspot/webrev.05
> As discussed on the call we had with Mario and Andrew Haley a few
> minutes ago we are all happy that this latest webrev minimizes the
> changes to startup order and, in particular, avoids any change to the
> order of class initialization.
>
> Andrew Haley sked me to confirm that  happy for it to be backported. So,
> this note counts as both a reviewer and maintainer approval.
>
> Andrew Hughes, could you please include this in the release as soon as
> possible.

Thanks everyone involved in this review! I have pushed the changeset
to jdk8u-dev/hotspot - is there anything else I need to do? Adding
'jdk8u-critical-request' label perhaps?

Cheers,

-JB-

>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill
>


More information about the jdk8u-dev mailing list