[8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

[Andrew Hughes]

On 11/06/2020 15:36, Andrew Dinn wrote:
> Hi Jaroslav,
> On 11/06/2020 11:50, Jaroslav Bachorík wrote:
>> I have reverted the change in the class initialization order and put
>> the JvmtiExport change in a guarded block as requested.
>> All tests are passing.
> . . .
>> The latest webrev:
>> http://cr.openjdk.java.net/~jbachorik/8233197/hotspot/webrev.05
> As discussed on the call we had with Mario and Andrew Haley a few
> minutes ago we are all happy that this latest webrev minimizes the
> changes to startup order and, in particular, avoids any change to the
> order of class initialization.
> 
> Andrew Haley sked me to confirm that  happy for it to be backported. So,
> this note counts as both a reviewer and maintainer approval.
> 
> Andrew Hughes, could you please include this in the release as soon as
> possible.
> 
> regards,
> 
> 
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill
> 

If this is for 8u262, it needs to be flagged with
jdk8u-critical-request. It looks like it was flagged with
jdk8u-fix-request and then pushed to 8u272 with jdk8u-fix-yes instead.

Jaroslav, can you please flag the bug with the appropriate
jdk8u-critical-fix label and I'll then formally approve it with
jdk8u-critical-yes. It can then be pushed to jdk8/jdk8 [0].

Note that the changeset should mention both 8233197 & the test bug
8246703, so that both will be marked as fixed in 8u262 i.e.

8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start()
start-up order for correct option parsing
8246703: [TESTBUG] Add test for JDK-8233197
Reviewed-by: aph, adinn, neugens

The current version in 8u-dev only seems to list the one bug and the
wrong reviewers.

Note that critical fixes for 8u262 don't need to be pushed to 8u272 as
well, as each build promotion for 8u262 is merged back into 8u-dev [1].

[0] https://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/
[1] https://wiki.openjdk.java.net/display/jdk8u/Detailed+Process+Description

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222