[8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

[Andrew Hughes]

On 11/06/2020 17:59, Jaroslav Bachorík wrote:
> snip ...
> 
>>
>> Note that the changeset should mention both 8233197 & the test bug
>> 8246703, so that both will be marked as fixed in 8u262 i.e.
>>
>> 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start()
>> start-up order for correct option parsing
>> 8246703: [TESTBUG] Add test for JDK-8233197
>> Reviewed-by: aph, adinn, neugens
>>
>> The current version in 8u-dev only seems to list the one bug and the
>> wrong reviewers.
> 
> Hmh, I was operating under an assumption that the backports should
> have the original reviewers and authors (which I admit I did wrong in
> this changeset - it slipped with me as an author and I noticed it only
> after pushing the changeset :( ).
> 

No problem. There is some ambiguity here that I've tried to explain on
the OpenJDK wiki (step #13, [0]).

Your assumption is correct where the backport is either clean (and so
you shouldn't even need to touch it anyway) or only requires minimal
context changes. In this case, the same patch is just being committed to
a different repository, so the only amendment necessary is to append any
additional reviewers (if any) from the 8u backport process.

For a patch like this that has had considerable development work and
review discussion, it seems inappropriate to not credit the people
involved in that process (both the committer and those who reviewed it).
It also seems incorrect to retain a review attribution to someone who
has probably not seen the backported version.

In this case, I think treating it as a new patch with its own committer
and reviewers is appropriate. The original credits are still there in
the jdk/jdk repositories and will live on longer than those in the
update projects. We should be crediting those who undertake backporting
work.

This becomes of most importance when it comes to proposing candidates
for committer or reviewer status. Backport patches that retain the
original metadata will not show up for those candidates.

> I will fix the metadata for 8u262 push then.

Thanks.

[0] https://wiki.openjdk.java.net/display/jdk8u/Main
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222