[8u] RFR 8183349: Better cleanup for jdk/test/javax/imageio/plugins/shared/CanWriteSequence.java and WriteAfterAbort.java

Zhengyu Gu zgu at redhat.com
Wed Jun 17 00:48:16 UTC 2020



On 6/16/20 7:43 PM, Andrew Hughes wrote:
> 
> 
> On 16/06/2020 22:09, Zhengyu Gu wrote:
>> Please review this backport for parity with Oracle 8u271.
>>
>> The original patch does not apply cleanly. The conflicts are minor, as
>> 8u version of CanWriteSequence.test() method format is slightly off.
>>
>> Original bug:  https://bugs.openjdk.java.net/browse/JDK-8183349
>> Original patch: http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/93b7bd25273e
>>
>> 8u weberv: http://cr.openjdk.java.net/~zgu/JDK-8183349-8u/webrev.00/
>>
>> Test:
>>    Passed both tests on Linux x86_64
>>
>>
>> Thanks,
>>
>> -Zhengyu
>>
> 
> Where are the indentation differences coming from in this patch? The
> only difference between the 8u and 10u version of this file prior to the
> patch is the latter has a newline at the end.
>
Right. Adding a newline in 8u version, then patch applied cleanly.

Do I still need a review?

Thanks,

-Zhengyu


> The attached is what I get from backporting the 11u changeset to 8u. It
> is nearly identical to the 11u version.
> 
> Thanks,
> 



More information about the jdk8u-dev mailing list