RFR: 8220293: Deadlock in JFR string pool

[Andrey Petushkov]

Hi Andrew,

On 17.06.2020 02:21, Andrew Hughes wrote:
>
> On 16/06/2020 19:12, Andrey Petushkov wrote:
>> Dear All,
>>
>> As suggested by Mario may I ask to include the backport of the
>> https://bugs.openjdk.java.net/browse/JDK-8220293 into 8u262 (that is,
>> critical request). The reason is that this is single severe (VM
>> deadlock) JFR bug we are aware of
>> The patch applies cleanly, except for file locations change. Just in
>> case here is the webrev https://cr.openjdk.java.net/~apetushkov/8220293/
>> (one actual code change is .hpp guard macro name change due to file
>> location change)
> This is confusing. Is the 8u patch different or not?
Ah, sorry. for confusion Yes, the patch is the same. The line in
question is part of diff context I was looking at, not the changed line
So yes, this is absolutely clean backport
>
> Shuffling the 11u changeset gave me the same patch as in your webrev,
> and that applied to 8u cleanly, so I'm inclined to think no changes are
> necessary here.
>
>> Verified by the test in the bug (deadlock in about 1 minute without the
>> fix, running fine for about 15 minutes a few times with the fix)
>>
>> Thanks,
>> Andrey
>>
> Approved for 8u262, assuming it is a clean backport.
Thank you,
Andrey
>
> Thanks,