[8u] RFR 8238225: Issues reported after replacing symlink at Contents/MacOS/libjli.dylib with binary

[Dmitry Cherepanov]

On 6/8/20 3:05 AM, Andrew Hughes wrote:
> On 17/04/2020 13:57, Dmitry Cherepanov wrote:
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8238225
>> original review:
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2020-January/064561.html
>>
>> patch for 11u:
>> https://hg.openjdk.java.net/jdk-updates/jdk11u/rev/128739be82b6
>>
>> webrev for 8u:
>> http://cr.openjdk.java.net/~dcherepanov/openjdk8u/8238225/webrev.v0/
>>
>> 1) src/macosx/bin/java_md_macosx.c
>>
>> This part applies cleanly but needs refinement. The logic has been
>> expanded to cover 8u-specifics: if the libjli.dylib library was loaded
>> from MacOS bundle (i.e. realPathToSelf ends with “/MacOS/libjli.dylib”),
>> then check if it’s a JDK bundle (private JRE is in ../Home/jre) and then
>> check if it’s a JRE bundle (public JRE is in ../Home)
>>
>> 2) testing part
>>
>> Given that support for building native part of jtpeg tests is currently
>> missing in 8u (8072842), new shell script was created and used for
>> testing.  The java part of the test also includes additional changes
>> relative to 11u version
>> (http://cr.openjdk.java.net/~dcherepanov/openjdk8u/8238225/JliLaunchTest.java.diff.v0).
>> The test fails without a fix and passes from the fixes (for JRE/JDK
>> bundles)
>>
>> Thanks,
>>
>> Dmitry
>>
> The patch:
>
> https://cr.openjdk.java.net/~dcherepanov/openjdk8u/8238225/webrev.v0/jdk.changeset
>
> appears to contain both 8235687 & 8238225. Which of these is actually
> being submitted for review?

This is review request for 8238225 only.
Review for 8235687 (for which 8238225 is a follow-up) was submitted 
separately [1] and it appears that 8235687 accidentally leaked into this 
patch.

It should be fixed at: 
http://cr.openjdk.java.net/~dcherepanov/openjdk8u/8238225/webrev.v1/

Thanks for catching this.

Dmitry

[1] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-April/011576.html