8214545: sun/management/jmxremote/bootstrap tests hang in revokeall.exe on Windows
Hohensee, Paul
hohensee at amazon.com
Fri Jun 19 17:01:15 UTC 2020
Lgtm. Andrew and Severin, I can't tag the JBS issue, so would you approve/disapprove here on the list please?
Thanks,
Paul
On 6/18/20, 3:46 PM, "Lutker, Dan" <lutkerd at amazon.com> wrote:
Thanks Paul,
Updated webrev without the extra file is here: http://cr.openjdk.java.net/~phh/8214545/webrev.8u.02/
Yes, we starting hitting the hang during our Tier2 runs in a new test bed we are spinning up, with this patch the runs complete fine.
-Dan
On 6/18/20, 12:48 PM, "Hohensee, Paul" <hohensee at amazon.com> wrote:
I assume (some of) the 8u jdk/test/sun/management/jmxremote/bootstrap tests were hanging without this patch.
https://bugs.openjdk.java.net/browse/JDK-8214545 corresponding to the patch isn't accessible. Oracle engineer(s), would it be possible to open it?
The original patch updates JtregNativeJdk.gmk, but I couldn't find the mechanism implemented by that file in 8 (perhaps another reviewer can comment), so omitting it seems correct.
There is an extra (duplicate) file test/jdk/sun/management/windows/exerevokeall.c in your webrev. Other than that, lgtm.
Thanks,
Paul
On 6/18/20, 9:38 AM, "jdk8u-dev on behalf of Lutker, Dan" <jdk8u-dev-bounces at openjdk.java.net on behalf of lutkerd at amazon.com> wrote:
Hi all,
I am backporting this to fix an issue with revokeall.exe hanging on Windows systems.
http://cr.openjdk.java.net/~phh/8214545/webrev.8u.01/
The new revokeall.exe was built on the test machine and the README was updated with the build command used for the new source file to create the old binary name.
The original change is here: http://hg.openjdk.java.net/jdk/jdk/rev/2ffbc00d87ae
Testing done:
Built images on Windows x64 and ran the jdk/sun/management tests, which all passed.
Thanks,
Dan
More information about the jdk8u-dev
mailing list