[RFR] [8u262] JDK-8248399: Build installs jfr binary when JFR is disabled

Severin Gehwolf sgehwolf at redhat.com
Fri Jun 26 15:37:01 UTC 2020


Hi Andrew,

On Fri, 2020-06-26 at 16:30 +0100, Andrew Hughes wrote:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8248399
> Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8248399/webrev.01/

This looks good to me.

> At present, the build still creates and installs a jfr binary even when
> JFR is disabled. Without jfr.jar, it is useless:
> 
> $ ~/builder/8u/images/j2sdk-image/bin/jfr
> Error: Could not find or load main class jdk.jfr.internal.tool.Main

Nice find.

> The fix is a simple conditional around the jfr launcher, as was added
> for the profiles in CopyFiles.gmk, but missed in the backport of
> JDK-8205516.
> 
> This should go into 8u262 before freeze at end of today, so I'll flag
> with jdk8u-critical-request once reviewed.

Please do.

Thanks,
Severin



More information about the jdk8u-dev mailing list