[8u] RFR: 8226892: ActionListeners on JRadioButtons don't get notified when selection is changed with arrow keys

Severin Gehwolf sgehwolf at redhat.com
Fri Mar 6 16:21:00 UTC 2020


Hi,

Could I please get a review of this patch for Oracle JDK 8u252 parity?
The JDK 11 patch does not apply cleanly (post path shuffeling) but the
changes needed were minimal:

 * src/share/classes/javax/swing/plaf/basic/BasicRadioButtonUI.java
   added copyright manually.
 * test/javax/swing/JRadioButton/8033699/bug8033699.java added
   copyright and bug id manually. The test didn't list bugs 8154043
   8167160 8208640 via @bug annotation. runTest9() hunk added manually
   due to context changes.

Bug: https://bugs.openjdk.java.net/browse/JDK-8226892
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8226892/01/webrev/

Testing: Regression test fails without the patch, passes after. Also
ran the manual test as described in the bug.

Once successfully reviewed, I'll flag it for inclusion in OpenJDK
8u252.

Thoughts?

Thanks,
Severin



More information about the jdk8u-dev mailing list