RFR: 8241307: Marlin renderer is used by default in jdk8u

Hohensee, Paul hohensee at amazon.com
Thu Mar 19 22:03:00 UTC 2020


Lgtm, except there's an extra blank line at the end of sun.java2d.pipe.RenderingEngine.

Thanks,
Paul

On 3/19/20, 2:24 PM, "jdk8u-dev on behalf of Laurent Bourgès" <jdk8u-dev-bounces at openjdk.java.net on behalf of bourges.laurent at gmail.com> wrote:    
    
    Please review this jdk8u specific patch to restore the default behaviour
    (Marlin renderer is not the default RenderingEngine).
    
    
    Note: this impacts the coming JDK8 b252 release too, sorry.
    
    
    
    JBS: https://bugs.openjdk.java.net/browse/JDK-8241307
    
    webrev: http://cr.openjdk.java.net/~lbourges/marlin8u/marlin-8241307.0/
    
    
    Changes:
    - fixed the class order sun.java2d.pipe.RenderingEngine files to ensure
    Marlin is not at the last place (default service)
    - new test DefaultRenderingEngine that fails if Marlin is the default
    rendering engine
    
    Build: OK
    JTreg fails without patch:
    runner starting test: sun/java2d/marlin/DefaultRenderingEngine.java
    runner finished test: sun/java2d/marlin/DefaultRenderingEngine.java
    Failed. Execution failed: `main' threw exception:
    java.lang.RuntimeException: Marlin must not be the default RenderingEngine
    in jdk8u !
    
    JTreg passes with patch:
    runner starting test: sun/java2d/marlin/DefaultRenderingEngine.java
    runner finished test: sun/java2d/marlin/DefaultRenderingEngine.java
    Passed. Execution successful
    
    PS: Thanks to Alexander to have reported this problem today.
    
    Laurent
    



More information about the jdk8u-dev mailing list