RFR: 8241307: Marlin renderer is used by default in jdk8u

[Andrew Hughes]

On 20/03/2020 15:36, Hohensee, Paul wrote:
> For the fix to go into 8u252, label the issue with 'jdk8u-critical-request' and remove the 'jdk8u-fix-request' label. I removed 'openjdk8u' from the Affects Version/s list because it only affects openjdk8u252.
> 
> Paul
> 
> On 3/20/20, 3:17 AM, "jdk8u-dev on behalf of Laurent Bourgès" <jdk8u-dev-bounces at openjdk.java.net on behalf of bourges.laurent at gmail.com> wrote:    
>     
>     Hi Andrew,
>     as 2 reviewers approved this patch, is it enough to push ?
>     
>     Should I add more labels to this jdk8u bug or wait for 8u maintainer
>     approval ?
>     
>     Could you then backport on OpenJDK8u 252 if you agree ?
>     
>     Cheers,
>     Laurent
>     
>     Le ven. 20 mars 2020 à 10:48, Alexander Scherbatiy <
>     alexander.scherbatiy at bell-sw.com> a écrit :
>     
>     > The fix looks good to me.
>     >
>     > Thanks,
>     >
>     > Alexander.
>     > On 20.03.2020 00:23, Laurent Bourgès wrote:
>     >
>     > Please review this jdk8u specific patch to restore the default behaviour
>     > (Marlin renderer is not the default RenderingEngine).
>     >
>     >
>     > Note: this impacts the coming JDK8 b252 release too, sorry.
>     >
>     >
>     >
>     > JBS: https://bugs.openjdk.java.net/browse/JDK-8241307
>     >
>     > webrev: http://cr.openjdk.java.net/~lbourges/marlin8u/marlin-8241307.0/
>     >
>     > Changes:
>     > - fixed the class order sun.java2d.pipe.RenderingEngine files to ensure
>     > Marlin is not at the last place (default service)
>     > - new test DefaultRenderingEngine that fails if Marlin is the default
>     > rendering engine
>     >
>     > Build: OK
>     > JTreg fails without patch:
>     > runner starting test: sun/java2d/marlin/DefaultRenderingEngine.java
>     > runner finished test: sun/java2d/marlin/DefaultRenderingEngine.java
>     > Failed. Execution failed: `main' threw exception:
>     > java.lang.RuntimeException: Marlin must not be the default RenderingEngine
>     > in jdk8u !
>     >
>     > JTreg passes with patch:
>     > runner starting test: sun/java2d/marlin/DefaultRenderingEngine.java
>     > runner finished test: sun/java2d/marlin/DefaultRenderingEngine.java
>     > Passed. Execution successful
>     >
>     > PS: Thanks to Alexander to have reported this problem today.
>     >
>     > Laurent
>     >
>     >
>     
> 

I think this is one for 8u262. We should have a cycle where Marlin is
available, not default, as with JFR.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222