RFR: 8241307: Marlin renderer is used by default in jdk8u

[Hohensee, Paul]

Andrew or Severin must tag the issue with ‘jdk8u-fix-yes’ first.

From: Laurent Bourgès <bourges.laurent at gmail.com>
Date: Friday, March 20, 2020 at 9:31 AM
To: "Hohensee, Paul" <hohensee at amazon.com>
Cc: Alexander Scherbatiy <alexander.scherbatiy at bell-sw.com>, jdk8u-dev <jdk8u-dev at openjdk.java.net>
Subject: RE: [EXTERNAL] RFR: 8241307: Marlin renderer is used by default in jdk8u

Paul,
can I already push in 8u-dev as the RFR is approved ?

Laurent

Le ven. 20 mars 2020 à 16:36, Hohensee, Paul <hohensee at amazon.com<mailto:hohensee at amazon.com>> a écrit :
For the fix to go into 8u252, label the issue with 'jdk8u-critical-request' and remove the 'jdk8u-fix-request' label. I removed 'openjdk8u' from the Affects Version/s list because it only affects openjdk8u252.

Paul

On 3/20/20, 3:17 AM, "jdk8u-dev on behalf of Laurent Bourgès" <jdk8u-dev-bounces at openjdk.java.net<mailto:jdk8u-dev-bounces at openjdk.java.net> on behalf of bourges.laurent at gmail.com<mailto:bourges.laurent at gmail.com>> wrote:

    Hi Andrew,
    as 2 reviewers approved this patch, is it enough to push ?

    Should I add more labels to this jdk8u bug or wait for 8u maintainer
    approval ?

    Could you then backport on OpenJDK8u 252 if you agree ?

    Cheers,
    Laurent

    Le ven. 20 mars 2020 à 10:48, Alexander Scherbatiy <
    alexander.scherbatiy at bell-sw.com<mailto:alexander.scherbatiy at bell-sw.com>> a écrit :

    > The fix looks good to me.
    >
    > Thanks,
    >
    > Alexander.
    > On 20.03.2020 00:23, Laurent Bourgès wrote:
    >
    > Please review this jdk8u specific patch to restore the default behaviour
    > (Marlin renderer is not the default RenderingEngine).
    >
    >
    > Note: this impacts the coming JDK8 b252 release too, sorry.
    >
    >
    >
    > JBS: https://bugs.openjdk.java.net/browse/JDK-8241307
    >
    > webrev: http://cr.openjdk.java.net/~lbourges/marlin8u/marlin-8241307.0/
    >
    > Changes:
    > - fixed the class order sun.java2d.pipe.RenderingEngine files to ensure
    > Marlin is not at the last place (default service)
    > - new test DefaultRenderingEngine that fails if Marlin is the default
    > rendering engine
    >
    > Build: OK
    > JTreg fails without patch:
    > runner starting test: sun/java2d/marlin/DefaultRenderingEngine.java
    > runner finished test: sun/java2d/marlin/DefaultRenderingEngine.java
    > Failed. Execution failed: `main' threw exception:
    > java.lang.RuntimeException: Marlin must not be the default RenderingEngine
    > in jdk8u !
    >
    > JTreg passes with patch:
    > runner starting test: sun/java2d/marlin/DefaultRenderingEngine.java
    > runner finished test: sun/java2d/marlin/DefaultRenderingEngine.java
    > Passed. Execution successful
    >
    > PS: Thanks to Alexander to have reported this problem today.
    >
    > Laurent
    >
    >