[8u] RFR: Backport of 8067796 (process) Process.waitFor(timeout, unit) doesn't throw NPE if timeout is less than, or equal to zero when unit == null

[Sergey Nazarkin]

Andrew, thanks for review. This patch is not critical and may be postponed for next release. 


Meanwhile I withdraw my review since I’ve found the test need further modifications.  And be reapplied on top of jdk8u-dev


Sergey Nazarkin




> On Mar 25, 2020, at 06:17, Andrew Hughes <gnu.andrew at redhat.com> wrote:
> 
> 
> 
> On 24/03/2020 17:09, Sergey Nazarkin wrote:
>> Hi!
>> 
>> Please review backport of the fix [1] for the issue [2]. The fix was originally made for jdk9 and included into oracle u251. It’s not applied cleanly due to file difference. 
>> 
>> Created ambrella case for the backport [3]
>> 
>> [1] http://cr.openjdk.java.net/~snazarki/8241535/
>> [2] https://bugs.openjdk.java.net/browse/JDK-8067796
>> [3] https://bugs.openjdk.java.net/browse/JDK-8241535
>> 
>> 
> 
> Please don't create backport bugs. These bugs are automatically created
> by the bug system on push for the appropriate release.
> 
> It would also be helpful for review if you could list the changes you
> had to make to create the backport and the reasons why.
> 
> This backport generally looks good, though there are a couple of minor
> issues:
> 
> * The original patch removes the empty line between the declaration of
> deadline and the do block, but this is missing from the backport in both
> files.
> * There is room in the test case for 8067796 to be appended to the line
> above. It doesn't need to be on a new line as in the original, because
> the line above is not full.
> 
> Please post a new webrev with these changes corrected.
> 
> If you want this patch to make 8u252, the bug needs to be flagged with
> jdk8u-critical-request tomorrow to make it in before we freeze for
> release. A comment should also be added as to why this is critical
> enough to be added to 8u252 at this late stage.
> 
> Thanks,
> -- 
> Andrew :)
> 
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
>