8u] RFR(xxs): 8241444: Metaspace::_class_vsm not initialized if compressed class pointers are disabled

[Hohensee, Paul]

I'll sponsor this.

Paul

On 3/24/20, 10:59 PM, "jdk8u-dev on behalf of Thomas Stüfe" <jdk8u-dev-bounces at openjdk.java.net on behalf of thomas.stuefe at gmail.com> wrote:    
    
    p.s. I would need a sponsor for this or committer access if I am to do this
    myself.
    
    Cheers, Thomas
    
    On Tue, Mar 24, 2020 at 4:30 PM Thomas Stüfe <thomas.stuefe at gmail.com>
    wrote:
    
    > Thanks Paul.
    >
    > On Tue, Mar 24, 2020 at 4:16 PM Hohensee, Paul <hohensee at amazon.com>
    > wrote:
    >
    >> Lgtm.
    >>
    >> Paul
    >>
    >> On 3/24/20, 8:05 AM, "jdk8u-dev on behalf of Thomas Stüfe" <
    >> jdk8u-dev-bounces at openjdk.java.net on behalf of thomas.stuefe at gmail.com>
    >> wrote:
    >>
    >>     Hi all,
    >>
    >>     May I have reviews for a trivial fix to Metaspace on jdk8 please.
    >>
    >>     It has been inadvertently fixed on JDK11 with "8199431: Split up class
    >>     Metaspace into a static and a non-static part" so its only an issue on
    >>     jdk8-10.
    >>
    >>     Issue:
    >>
    >>     https://bugs.openjdk.java.net/browse/JDK-8241444
    >>
    >>     Patch:
    >>
    >>     thomas at mainframe:/shared/projects/openjdk/jdk8udev/source/hotspot$
    >> hg diff
    >>     diff -r e6a26331730f src/share/vm/memory/metaspace.cpp
    >>     --- a/src/share/vm/memory/metaspace.cpp Fri May 08 14:00:24 2015 -0400
    >>     +++ b/src/share/vm/memory/metaspace.cpp Tue Mar 24 15:53:17 2020 +0100
    >>     @@ -3390,6 +3390,8 @@
    >>        if (using_class_space()) {
    >>          // Allocate SpaceManager for classes.
    >>          _class_vsm = new SpaceManager(ClassType, lock);
    >>     +  } else {
    >>     +    _class_vsm = NULL;
    >>        }
    >>
    >>        MutexLockerEx cl(SpaceManager::expand_lock(),
    >>     Mutex::_no_safepoint_check_flag);
    >>
    >>     --------------
    >>
    >>     I guess I need a sponsor since I am not a committer for 8u.
    >>
    >>     Thanks, Thomas
    >>
    >>
    >>