RFR: 8241902: AIX Build broken after integration of JDK-8223147 (JFR Backport)

[Doerr, Martin]

+1

Best regards,
Martin


> -----Original Message-----
> From: Andrey Petushkov <andrey at azul.com>
> Sent: Dienstag, 31. März 2020 17:52
> To: Langer, Christoph <christoph.langer at sap.com>; Doerr, Martin
> <martin.doerr at sap.com>; jdk8u-dev at openjdk.java.net
> Cc: Baesken, Matthias <matthias.baesken at sap.com>
> Subject: Re: RFR: 8241902: AIX Build broken after integration of JDK-8223147
> (JFR Backport)
> 
> Hi Christoph,
> 
> Thank you, looks good
> 
> Andrey
> 
> On 31.03.2020 16:34, Langer, Christoph wrote:
> > Hi,
> >
> > Andrey, Martin, thanks for the review.
> >
> > Having a configure check is a good suggestion. Here is the webrev:
> http://cr.openjdk.java.net/~clanger/webrevs/8241902.main.8u/
> >
> > I'll push both changes under https://bugs.openjdk.java.net/browse/JDK-
> 8241902.
> >
> > Thanks
> > Christoph
> >
> >
> >> -----Original Message-----
> >> From: Andrey Petushkov <andrey at azul.com>
> >> Sent: Dienstag, 31. März 2020 12:11
> >> To: Doerr, Martin <martin.doerr at sap.com>; Langer, Christoph
> >> <christoph.langer at sap.com>; jdk8u-dev at openjdk.java.net
> >> Cc: Baesken, Matthias <matthias.baesken at sap.com>
> >> Subject: Re: RFR: 8241902: AIX Build broken after integration of JDK-
> 8223147
> >> (JFR Backport)
> >>
> >> Hi All,
> >>
> >> This looks good to me, however note I'm not a reviewer
> >> One question, don't you want to fail configure on AIX if --enable-jfr is
> >> supplied?
> >> And sorry for making you this trouble
> >>
> >> Regards,
> >> Andrey
> >>
> >> On 31.03.2020 12:49, Doerr, Martin wrote:
> >>> Hi Christoph,
> >>>
> >>> thanks for fixing ti.
> >>> Looks good to me, but I'm not a makefile / build expert.
> >>>
> >>> Best regards,
> >>> Martin
> >>>
> >>>
> >>> From: Langer, Christoph <christoph.langer at sap.com>
> >>> Sent: Dienstag, 31. März 2020 11:40
> >>> To: jdk8u-dev at openjdk.java.net
> >>> Cc: Doerr, Martin <martin.doerr at sap.com>; Lindenmaier, Goetz
> >> <goetz.lindenmaier at sap.com>
> >>> Subject: RFR: 8241902: AIX Build broken after integration of JDK-8223147
> >> (JFR Backport)
> >>> Hi,
> >>>
> >>> integrating the JFR backport into jdk8u-dev has broken the AIX build.
> >> Please review the following (8-only) change for the hotspot sub
> repository
> >> that will repair it:
> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8241902
> >>> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8241902.8u/
> >>>
> >>> Note that this will only fix the default build with JFR disabled. Building
> and
> >> using an 8u JDK with JFR enabled on AIX is likely to fail, though. SAP,
> >> however, has no plans to add full support for JFR on AIX to OpenJDK 8u.
> >>> Thanks
> >>> Christoph