[8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing
Mario Torre
neugens at redhat.com
Wed May 6 10:36:49 UTC 2020
Hi Jaroslav,
Sorry I dropped the ball on this one, I went through the changes and
they all seem good to me.
We need a maintainer to set the jdk8u-fix-yes flag before you can
push, but the review is ok.
Cheers,
Mario
On Fri, Apr 24, 2020 at 12:20 PM Jaroslav Bachorík
<jaroslav.bachorik at datadoghq.com> wrote:
>
> Resending again in plain text to make the filters pass.
>
> ---------- Forwarded message ---------
> From: Jaroslav Bachorík <jaroslav.bachorik at datadoghq.com>
> Date: Mon, Apr 20, 2020 at 4:02 PM
> Subject: [8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized()
> and Jfr:on_vm_start() start-up order for correct option parsing
> To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
>
>
> Please review the following backport
>
> JIRA. : https://bugs.openjdk.java.net/browse/JDK-8233197
> Webrev. : http://cr.openjdk.java.net/~jbachorik/8233197/
>
> The backport patch applied rather cleanly, not considering several
> offset adjustments.
> The only part that required an additional change was modifying the
> place where java lang classes initialization happens in thread.cpp -
> those classes need to be initialized before 'Jfr::on_create_vm_2()' is
> called. In order to achieve this I just moved around the whole
> codeblock related to java lang classes initialization.
>
> All tests from jdk_jfr are passing after this patch has been applied.
>
> Thanks!
>
> -JB-
>
--
Mario Torre
Associate Manager, Software Engineering
Red Hat GmbH <https://www.redhat.com>
9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
More information about the jdk8u-dev
mailing list