[aarch64-port-dev ] Fwd: RFR: Backport: 8217368: AArch64: C2 recursive stack locking optimisation not triggered

[Andrew Dinn]

On 07/05/2020 10:53, Andrew Dinn wrote:
> This is Nick Gasson's patch, stripped of the changes that were due
> to adaptations made because of later changes to MacroAssembler.
> 
> http://cr.openjdk.java.net/~aph/aarch64-jdk8u/8217368.patch
Well, this patch looks fine apart from the small detail that the line at
which it is to be applied is wrong. I managed to apply it but only with
a suitable fuzz:

  "Hunk #1 succeeded at 3333 with fuzz 1 (offset -1506 lines)."

Is the line number disparity there because this is /literally/ the
original jdk13u patch Nick suggested on the mail thread? Or is there
something else I have missed?

That aside I entirely agree that this is the correct /backport/ patch.
It precisely fixes the original problem without pulling in all the
gubbins that was approrpiate upstream in order to remove technical debt.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill