[aarch64-port-dev ] Fwd: RFR: Backport: 8217368: AArch64: C2 recursive stack locking optimisation not triggered

[Andrew Haley]

On 5/7/20 11:32 AM, Andrew Dinn wrote:
> On 07/05/2020 10:53, Andrew Dinn wrote:
>> This is Nick Gasson's patch, stripped of the changes that were due
>> to adaptations made because of later changes to MacroAssembler.
>>
>> http://cr.openjdk.java.net/~aph/aarch64-jdk8u/8217368.patch
> Well, this patch looks fine apart from the small detail that the line at
> which it is to be applied is wrong. I managed to apply it but only with
> a suitable fuzz:
> 
>   "Hunk #1 succeeded at 3333 with fuzz 1 (offset -1506 lines)."
> 
> Is the line number disparity there because this is /literally/ the
> original jdk13u patch Nick suggested on the mail thread? Or is there
> something else I have missed?

I have no idea! I'm surprised that hg import looks 1506 lines away.

> That aside I entirely agree that this is the correct /backport/ patch.
> It precisely fixes the original problem without pulling in all the
> gubbins that was approrpiate upstream in order to remove technical debt.

OK.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671