[aarch64-port-dev ] Fwd: RFR: Backport: 8216989: CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does not check for zero length on AARCH64

[Andrew Haley]

On 5/7/20 11:43 AM, Andrew Dinn wrote:
> On 07/05/2020 10:53, Andrew Dinn wrote:
>> Forwarding to also include jdk8u-dev
>>
>>
>> -------- Forwarded Message --------
>> Subject: [aarch64-port-dev ] RFR: Backport: 8216989:
>> CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does
>> not check for zero length on AARCH64
>> Date: Thu, 7 May 2020 10:14:23 +0100
>> From: Andrew Haley <aph at redhat.com>
>> To: aarch64-port-dev at openjdk.java.net <aarch64-port-dev at openjdk.java.net>
>>
>> The final patch for this bug was very complex and did not apply to
>> jdk8u. This patch is almost identical to Dmitrij Pochepko's first
>> proposal, so he still gets the credit. It is also far, far simpler
>> than the final patch.
>>
>> http://cr.openjdk.java.net/~aph/aarch64-jdk8u/8216989.patch
> Hmm, indeed, unbelievably simpler and yet still correct. All those
> layers of abstraction the upstream patch had to work its way through
> must be buying us something though, surely? ;->

You might like to think so; I couldn't possibly comment.

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671