[8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized() and Jfr:on_vm_start() start-up order for correct option parsing

[Jaroslav Bachorík]

Hi Mario,

thanks for the review and I apologize for the escaped non-needed
commented out code.
Everything is cleaned up now and should correspond to 11u backport.

Webrev 01: http://cr.openjdk.java.net/~jbachorik/8233197/hotspot/webrev.01/

Cheers,

-JB-

On Mon, May 11, 2020 at 2:24 PM Mario Torre <neugens at redhat.com> wrote:
>
> Hi Jaroslav,
>
> I went back to that and I noticed some minor things while comparing it
> to the original patch.
>
> I see you have a number of commented out blocks, I think those should
> be removed, I can see how this may become a problem when backporting
> additional fixes. For example:
>
> +void Jfr::on_create_vm_1() {
> +  //jio_fprintf(defaultStream::error_stream(), "openjdk version
> \"1.8.0-internal-debug\"\n");
> +  if (!JfrRecorder::on_create_vm_1()) {
> +    vm_exit_during_initialization("Failure when starting JFR on_create_vm_1");
>    }
>
> Also, you changed the assert in linkResolver.cpp, at first I thought
> this was intentional, but there no such change in jdk11. Perhaps it
> may be dropped?
>
> Cheers,
> Mario
>
>
> On Wed, May 6, 2020 at 12:36 PM Mario Torre <neugens at redhat.com> wrote:
> >
> > Hi Jaroslav,
> >
> > Sorry I dropped the ball on this one, I went through the changes and
> > they all seem good to me.
> >
> > We need a maintainer to set the jdk8u-fix-yes flag before you can
> > push, but the review is ok.
> >
> > Cheers,
> > Mario
> >
> >
> > On Fri, Apr 24, 2020 at 12:20 PM Jaroslav Bachorík
> > <jaroslav.bachorik at datadoghq.com> wrote:
> > >
> > > Resending again in plain text to make the filters pass.
> > >
> > > ---------- Forwarded message ---------
> > > From: Jaroslav Bachorík <jaroslav.bachorik at datadoghq.com>
> > > Date: Mon, Apr 20, 2020 at 4:02 PM
> > > Subject: [8u] RFR 8233197: Invert JvmtiExport::post_vm_initialized()
> > > and Jfr:on_vm_start() start-up order for correct option parsing
> > > To: jdk8u-dev <jdk8u-dev at openjdk.java.net>
> > >
> > >
> > > Please review the following backport
> > >
> > > JIRA.     : https://bugs.openjdk.java.net/browse/JDK-8233197
> > > Webrev. : http://cr.openjdk.java.net/~jbachorik/8233197/
> > >
> > > The backport patch applied rather cleanly, not considering several
> > > offset adjustments.
> > > The only part that required an additional change was modifying the
> > > place where java lang classes initialization happens in thread.cpp -
> > > those classes need to be initialized before 'Jfr::on_create_vm_2()' is
> > > called. In order to achieve this I just moved around the whole
> > > codeblock related to java lang classes initialization.
> > >
> > > All tests from jdk_jfr are passing after this patch has been applied.
> > >
> > > Thanks!
> > >
> > > -JB-
> > >
> >
> >
> > --
> > Mario Torre
> > Associate Manager, Software Engineering
> > Red Hat GmbH <https://www.redhat.com>
> > 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>
>
>
> --
> Mario Torre
> Associate Manager, Software Engineering
> Red Hat GmbH <https://www.redhat.com>
> 9704 A60C B4BE A8B8 0F30  9205 5D7E 4952 3F65 7898
>