RFR: Backport: 823751: AArch64: aarch64TestHook leaks a BufferBlob

Andrew Haley aph at redhat.com
Tue May 12 12:02:34 UTC 2020


This is Nick Gasson's patch, adjusted but not changed in any significant
way:

http://cr.openjdk.java.net/~aph/aarch64-jdk8u/8237512.webrev/

<musing>

Just out of curiosity, I looked at when this bug dates from, and I
see

# User aph
# Date 1342803468 -3600
#      Fri Jul 20 17:57:48 2012 +0100
Assembler bug fixes

diff -r 0267a9670f59 -r f561ffc8c13f src/cpu/aarch64/vm/aarch64Test.cpp
--- a/src/cpu/aarch64/vm/aarch64Test.cpp        Fri Jul 20 12:39:25 2012 +0100
+++ b/src/cpu/aarch64/vm/aarch64Test.cpp        Fri Jul 20 17:57:48 2012 +0100
@@ -17,7 +17,7 @@

 void aarch64TestHook()
 {
-  BufferBlob* b = BufferBlob::create("aarch64Test", 5000);
+  BufferBlob* b = BufferBlob::create("aarch64Test", 500000);

This was right at the beginning, when we were writing the assembler,
and I needed some way to make sure the generated code was correct but
we had no hardware.

It's hard to remember what I was thinking, but I guess I thought that
this was only test code, so it didn't matter. How wrong can you be? ��
Memo to self: don't do that again.

</musing>

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the jdk8u-dev mailing list