[8u] RFR 8244407: JVM crashes after transformation in C2 IdealLoopTree::split_fall_in

[Andrew Hughes]

On 25/05/2020 03:18, Yangfei (Felix) wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Andrew Hughes [mailto:gnu.andrew at redhat.com]
>> Sent: Monday, May 25, 2020 10:09 AM
>> To: Yangfei (Felix) <felix.yang at huawei.com>; 'jdk8u-dev at openjdk.java.net'
>> <jdk8u-dev at openjdk.java.net>
>> Subject: Re: [8u] RFR 8244407: JVM crashes after transformation in C2
>> IdealLoopTree::split_fall_in
>>
>>
>>
>> On 22/05/2020 05:34, Yangfei (Felix) wrote:
>>> Hi,
>>>
>>> Original bug:
>>>   https://bugs.openjdk.java.net/browse/JDK-8244407
>>>   https://hg.openjdk.java.net/jdk/jdk/rev/c9f5a16d6980
>>>
>>> Original patch doesn't apply cleanly due to conflict on the copyright header
>> update and file path difference, no other conflicts witnessed.
>>>
>>> 8u webrev:
>>>   http://cr.openjdk.java.net/~fyang/8244407-8u-backport/
>>>
>>> Testing: Run full jtreg test with a x86-64 & aarch64 release build.
>>>
>>> OK to backport?
>>>
>>> Thanks,
>>> Felix
>>>
>>
>> Copyright header changes should only be dropped if the existing year is the
>> same or later than that in the patch. In this case, the patch updates the year
>> to 2020, but 8u only has 2017, so the change should be manually applied to
>> bump the file in 8u to 2020.
> 
> Do you mean this file: src/share/vm/opto/loopnode.cpp?
> I read this before: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-February/011224.html 
> Is there anything different for this case?
> 
> Thanks,
> Felix
> 

I believe that was in reference to a copyright change being created for
the backport.

In this case, the copyright header change has wrongly been removed, when
compared to the original patch. It should be reinstated.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222