[8u] RFR(XS) 8245617: ObjectSizeCalculator is not supported on OpenJDK

[Andrew Hughes]

On 25/05/2020 01:58, Yangfei (Felix) wrote:
> 
> 
>> -----Original Message-----
>> From: Andrew Hughes [mailto:gnu.andrew at redhat.com]
>> Sent: Saturday, May 23, 2020 6:42 PM
>> To: Yangfei (Felix) <felix.yang at huawei.com>; Andrew Haley
>> <aph at redhat.com>; 'jdk8u-dev at openjdk.java.net' <jdk8u-
>> dev at openjdk.java.net>
>> Subject: Re: [8u] RFR(XS) 8245617: ObjectSizeCalculator is not supported on
>> OpenJDK
>>
> 
> snip...
> 
>>
>> For the record, this is only not applicable to 11u and later because it was
>> removed by JDK-8189617.
>>
>> At the time of removal, it still had this code, unfixed for OpenJDK.
>> It seems trying to fix this was actually the motivation for removing it
>> altogether, because it's completely broken with the OpenJDK 9 module &
>> versioning changes:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8171934
>>
>> I've reopened that and this fix to 8u should be pushed under that ID.
>> 8245617 has been closed as a dupe.
> 
> Thanks for the info.
> Webrev: http://cr.openjdk.java.net/~fyang/8171934/webrev.00/ 
> 
>>>
>>>> Anyway, never mind, it's not worth spending any more time thinking
>> about.
>>>>
>>>> Your patch is OK, thanks.
>>>
>>> Thanks for the quick review.  Will push this trivial change.
>>>
>>> Felix
>>>
>>
>> Pushes to jdk8u require jdk8u-fix-yes
>> (https://wiki.openjdk.java.net/display/jdk8u/Main, step #11). Please flag
>> JDK-8171934 with a jdk8u-fix-request and I'll approve.
> 
> I have labeled JDK-8171934 with jdk8u-fix-request.  Please take a look.
> 
> Felix
> 

Thanks. Approved and pushed, will be part of jdk8u262-b04.
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222