[8u] TLSv1.3 RFR: 8245469: Remove DTLS protocol implementation

Andrew Brygin abrygin at azul.com
Thu May 28 15:11:50 UTC 2020


Hello Martin,

On 27/05/2020 18:32, Martin Balao wrote:
> 
> On 5/27/20 6:30 AM, Alexey Bakhtin wrote:
>>
>> It is similar to changes in the OutputRecord.java / InputRecord.java classes.
>> If we leave enableRetransmissions in the code it could lead to misleading that retransmission
>> could be enabled or used.
>> I'd suggest to remove it.
> 
> Hmm.. yes, part of this comment is related to OutputRecord.java /
> InputRecord.java. I understand your point about cleaning up the code.
> But the other side of the argument is that we now have the burden of
> supporting 8u-specifics in future backports. In other words, if we have
> a conflict near this code -which is now more likely-, we will probably
> need to think about fragmentation again and why the code is different
> than in 11u. As said before, I see arguments on both sides and even
> though I'm a bit more inclined to keep the code as similar as possible,
> I'm okay if you want to go the remove way.
> 

I would vote for the removal of the unused code. I understand the point
that the similarity with 11u would make future backports more convenient
in some cases. However, the implementations in 8u and 11u will be
different anyway, and I think that the some decrease of fragmentation
does not worth the risk of a misleading inducted by unused code.

Thanks,
Andrew



More information about the jdk8u-dev mailing list