[8u] TLSv1.3 RFR: 8245468: Add TLSv1.3 implementation classes from 11.0.7

Alexey Bakhtin alexey at azul.com
Thu May 28 19:37:22 UTC 2020


Hello Dmitry,

Thank you for review.

These methods of the BaseSSLSocketImpl class were initially removed in the first version of JDK-8245469 patch :
http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245469/webrev.v0/

As part of review findings [1], it was decided to move these modifications to JDK-8245470.
I’ve updated JDK-8245469 webrev : http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245469/webrev.v1/
but do not update JDK-8245470 webrev yet.
I planed to update it as part of  JDK-8245470 review.

To fix build issues you can just delete setOption / getOption / supportedOptions methods from the src/share/classes/sun/security/ssl/BaseSSLSocketImpl.java

[1] - https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-May/011799.html

Regards
Alexey

> On 28 May 2020, at 22:08, Dmitry Cherepanov <dcherepanov at azul.com> wrote:
> 
> On 21.05.2020 16:08, Alexey Bakhtin wrote:
>> Please review changes required to backport TLSv1.3 protocol from JDK11.0.7 to JDK8u
>> 
>> This is the second part of backport discussed in the thread [1]
>> 
>> JBS task: https://bugs.openjdk.java.net/browse/JDK-8245468
>> Webrev: http://cr.openjdk.java.net/~abakhtin/tls1.3/8245466/8245468/webrev.v0/
>> 
>> This patch adds TLSv1.3 implementation classes from 11.0.7 and fixes issues discussed in [2]
> 
> When building 8u repo with all patched applied, I’m getting a build failure.
> 
> …/src/share/classes/sun/security/ssl/BaseSSLSocketImpl.java:643: error: method does not override or implement a method from a supertype
>     @Override
> 
> It looks like, as a part of this step, we automatically (and unintentionally?) included the patch for JDK-8040062 but it depends on new API added by JDK-8036979 (not in 8u).
> 
> Thanks
> 
> Dmitry
> 
> 



More information about the jdk8u-dev mailing list